-
Notifications
You must be signed in to change notification settings - Fork 473
Closes #3871: Autocomplete incorrectly fills urls that contains a port number. #3847
Conversation
@Mihai-Adrian Before merging, I did some minimal changes.
|
Thank you, I will keep these in consideration for the future pull requests. |
Thank you for the great job 🥇! |
Codecov Report
@@ Coverage Diff @@
## master #3847 +/- ##
===========================================
+ Coverage 80.31% 80.6% +0.28%
- Complexity 3416 3613 +197
===========================================
Files 457 470 +13
Lines 15132 15738 +606
Branches 2269 2379 +110
===========================================
+ Hits 12154 12685 +531
- Misses 2046 2094 +48
- Partials 932 959 +27
Continue to review full report at Codecov.
|
8 similar comments
Codecov Report
@@ Coverage Diff @@
## master #3847 +/- ##
===========================================
+ Coverage 80.31% 80.6% +0.28%
- Complexity 3416 3613 +197
===========================================
Files 457 470 +13
Lines 15132 15738 +606
Branches 2269 2379 +110
===========================================
+ Hits 12154 12685 +531
- Misses 2046 2094 +48
- Partials 932 959 +27
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3847 +/- ##
===========================================
+ Coverage 80.31% 80.6% +0.28%
- Complexity 3416 3613 +197
===========================================
Files 457 470 +13
Lines 15132 15738 +606
Branches 2269 2379 +110
===========================================
+ Hits 12154 12685 +531
- Misses 2046 2094 +48
- Partials 932 959 +27
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3847 +/- ##
===========================================
+ Coverage 80.31% 80.6% +0.28%
- Complexity 3416 3613 +197
===========================================
Files 457 470 +13
Lines 15132 15738 +606
Branches 2269 2379 +110
===========================================
+ Hits 12154 12685 +531
- Misses 2046 2094 +48
- Partials 932 959 +27
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3847 +/- ##
===========================================
+ Coverage 80.31% 80.6% +0.28%
- Complexity 3416 3613 +197
===========================================
Files 457 470 +13
Lines 15132 15738 +606
Branches 2269 2379 +110
===========================================
+ Hits 12154 12685 +531
- Misses 2046 2094 +48
- Partials 932 959 +27
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3847 +/- ##
===========================================
+ Coverage 80.31% 80.6% +0.28%
- Complexity 3416 3613 +197
===========================================
Files 457 470 +13
Lines 15132 15738 +606
Branches 2269 2379 +110
===========================================
+ Hits 12154 12685 +531
- Misses 2046 2094 +48
- Partials 932 959 +27
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3847 +/- ##
===========================================
+ Coverage 80.31% 80.6% +0.28%
- Complexity 3416 3613 +197
===========================================
Files 457 470 +13
Lines 15132 15738 +606
Branches 2269 2379 +110
===========================================
+ Hits 12154 12685 +531
- Misses 2046 2094 +48
- Partials 932 959 +27
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3847 +/- ##
===========================================
+ Coverage 80.31% 80.6% +0.28%
- Complexity 3416 3613 +197
===========================================
Files 457 470 +13
Lines 15132 15738 +606
Branches 2269 2379 +110
===========================================
+ Hits 12154 12685 +531
- Misses 2046 2094 +48
- Partials 932 959 +27
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3847 +/- ##
===========================================
+ Coverage 80.31% 80.6% +0.28%
- Complexity 3416 3613 +197
===========================================
Files 457 470 +13
Lines 15132 15738 +606
Branches 2269 2379 +110
===========================================
+ Hits 12154 12685 +531
- Misses 2046 2094 +48
- Partials 932 959 +27
Continue to review full report at Codecov.
|
changed '/' position , after port number, in order to correctly show suggestions for addresses containing port numbers
Pull Request checklist
After merge